Repository navigation
Select node installation behavior from Provider declarations - #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The node installer now selects host checks, service-user checks, native configuration, Runtime preparation and service dependencies from one Provider table. Its supported node Providers come from the existing generated deployment declaration, removing repeated lists and implicit fallback to microsandbox for unknown Providers.
The refactor preserves device/group restrictions, check order before host changes, native store ownership, immutable image verification, generation helpers and uninstall recovery. The Python suite retains its existing assertions and adds coverage for declaration consistency, unsupported Providers and failure ordering.
Validation: complete Python node suite, 140 passed and two environment skips (root-only helper transfer and unavailable keyctl); Go Providers, 450 passed and one missing-database skip; focused declaration/artifact checks, 32 passed with no skips; distribution manifest, 28 passed. Full coordinator review and AST comparison of moved behavior completed. No database or native execution behavior changes; final live qualification remains with the cutover integration lane.
Fresh independent review found no substantiated in-scope issues. Rebasing onto cutover after #584 preserved the complete patch and identical node sources.
All applicable PR checks passed: distribution/installer packaging, hygiene, plan and the aggregate gate. Other groups were excluded by the repository’s path-based CI selection.