Repository navigation
CH-296 Allow a custom command for workflow exit handlers - #879
Open
afonsobspinto wants to merge 2 commits into
Open
afonsobspinto wants to merge 2 commits into
afonsobspinto wants to merge 2 commits into
Conversation
This was referenced Oct 15, 2026
afonsobspinto
added this pull request to stack #881
October 15, 2026 21:05
afonsobspinto
removed this pull request from stack #881
October 15, 2026 21:39
afonsobspinto
added this pull request to stack #882
October 15, 2026 21:39
afonsobspinto
force-pushed
the
feature/CH-296
branch
from
October 15, 2026 21:40
3219933 to
37de39c
Compare
afonsobspinto
marked this pull request as ready for review
October 15, 2026 21:49
afonsobspinto
removed this pull request from stack #882
October 15, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-296.
Implemented solution
Forward the optional
on_exit_notify.commandto the generated exit-handler container. Previously, a custom image still ran its default startup command.How to test this PR
From the repository root:
conda activate ch cd libraries/cloudharness-common python -m pytest -q tests/test_on_exit_notify.pyThese five tests render workflows locally; no Kubernetes or Kafka is required. Check that:
exit-handler.container.command, withspec.onExitpointing to that handler.Sanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):