Repository navigation
CH-295 Support Kubernetes Secret references in workflow tasks - #878
Closed
afonsobspinto wants to merge 1 commit into
Closed
afonsobspinto wants to merge 1 commit into
afonsobspinto wants to merge 1 commit into
Conversation
This was referenced Oct 15, 2026
afonsobspinto
added this pull request to stack #881
October 15, 2026 21:05
afonsobspinto
removed this pull request from stack #881
October 15, 2026 21:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-295.
Implemented solution
Workflow tasks currently stringify
secret_envsinstead of rendering the Kubernetes Secret references. Add an optionalCustomTask.secret_envsargument that appends structured environment entries alongside existing literal variables. Kubernetes resolves the credentials; their values are not embedded in the workflow.How to test this PR
Activate the repository's
chconda environment, then run:cd libraries/cloudharness-common python -m pytest -q tests/test_workflow.py tests/test_on_exit_notify.pySanity checks:
Breaking changes (select one):
breaking-changeand the migration procedure is described abovePossible deployment updates issues (select one):
alert:deploymentTest coverage (select one):
Documentation (select one):
Nice to have (if relevant):