Skip to content

Fix for SampleTypeNameExpressionTest #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DariaBod wants to merge 2 commits into from
+2 −1
Closed

Fix for SampleTypeNameExpressionTest #2974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933209c
change help target xpath
DariaBod May 4, 2026
1f0ebe7
xpath depends on page
DariaBod May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/org/labkey/test/components/ui/domainproperties/EntityTypeDesigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,8 @@ Optional<WebElement> optionalWarningAlert()

public final WebElement helpTarget(String divLabelText)
{
return Locator.xpath(String.format("//span[text()='%s']//div[@class='overlay-trigger']", divLabelText)).findWhenNeeded(this);
String element = getThis().getClass().getSimpleName().contains("SampleType")? "div" : "span";
return Locator.xpath(String.format("//%s[text()='%s']//div[@class='overlay-trigger']", element, divLabelText)).findWhenNeeded(this);
}

// Tool tips exist on the page, outside the scope of the domainDesigner, so scope the search accordingly.
Expand Down
Loading