Fix for SampleTypeNameExpressionTest

[DariaBod]

Rationale

SampleTypeNameExpressionTest.testNameExpressionPreview, SampleTypeNameExpressionTest.testErrorsAndWarnings failed with message "Unable to find element: xpath=//span[text()='Naming ']//div[@Class='overlay-trigger']". Element xpath changed.

Related Pull Requests

Changes

• Changed xpath

[labkey-tchad]

The class name shouldn't be functionally significant like this.

Also, I don't think this is the correct fix. The DOM structure isn't dependent on the entity type, i depends on whether it is in app or not. If you look at the sample type designer in LKS, it matches the old Locator. The new Locator works in LKSM and LKB.

Platform is still using @labkey/components without the accessibility improvements behind this.

@labkey-susanh When do we bump the components version in platform modules?

[labkey-susanh]

The class name shouldn't be functionally significant like this.

Also, I don't think this is the correct fix. The DOM structure isn't dependent on the entity type, i depends on whether it is in app or not. If you look at the sample type designer in LKS, it matches the old Locator. The new Locator works in LKSM and LKB.

Platform is still using @labkey/components without the accessibility improvements behind this.

@labkey-susanh When do we bump the components version in platform modules?

I can update platform to the new version in this branch if that works. Otherwise, I can do it in next accessibility branch. Let me know what's preferable.

[labkey-susanh]

The class name shouldn't be functionally significant like this.
Also, I don't think this is the correct fix. The DOM structure isn't dependent on the entity type, i depends on whether it is in app or not. If you look at the sample type designer in LKS, it matches the old Locator. The new Locator works in LKSM and LKB.
Platform is still using @labkey/components without the accessibility improvements behind this.
@labkey-susanh When do we bump the components version in platform modules?

I can update platform to the new version in this branch if that works. Otherwise, I can do it in next accessibility branch. Let me know what's preferable.

The platform versions are also being updated with Cory's PR, which will include these changes.

[labkey-tchad]

I can update platform to the new version in this branch if that works. Otherwise, I can do it in next accessibility branch. Let me know what's preferable.

The platform versions are also being updated with Cory's PR, which will include these changes.

It depends on the ETA of Cory's update. We could probably afford to mute the test failure for a couple of days.
Daria's monitoring these tests for May; I'll leave it up to her whether she'd like it updated sooner so that we don't have to mute the failure on TeamCity.

[DariaBod]

Cory's changes will naturally fix these tests.