Accessibility improvements: add labels or aria-labels to input elements#1991
Merged
labkey-susanh merged 34 commits intodevelopfrom May 1, 2026
Merged
Accessibility improvements: add labels or aria-labels to input elements#1991labkey-susanh merged 34 commits intodevelopfrom
labkey-susanh merged 34 commits intodevelopfrom
Conversation
…le/disable toggle" present
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cnathe
approved these changes
Apr 30, 2026
| return null; | ||
| } | ||
|
|
||
| const suffix = chartConfig.measures.series?.name ?? 'unknown'; |
Contributor
There was a problem hiding this comment.
does the usages of this suffix need to use the stringToHtmlId helper?
Contributor
Author
There was a problem hiding this comment.
Yes, that's one of the changes I have locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
For better accessibility of our input forms, we need to provide proper labels for each input field.
Related Pull Requests
Changes
aria-labelwhen there is no labelhtmlForandidwhen for labels and fields that were not associated with each othersr-onlyelements that can provide text where we used only iconsstringToHtmlIdmethod for constructing valid HTML ids from field names, etc.