Skip to content

Fix std::numeric_limits missing include for NNEF-Tools target #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kiritigowda merged 1 commit into from
Jul 15, 2026
Merged

Fix std::numeric_limits missing include for NNEF-Tools target #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ env:
OPENVX_DIR: ${{ github.workspace }}/install/Linux/x64/Debug
VX_TEST_DATA_PATH: ${{ github.workspace }}/cts/test_data/
# Full feature set built into a single library so one build serves every test.
# NNEF is included; the bundled NNEF-Tools submodule uses std::numeric_limits
# without including <limits>, so it is force-included for the C++ compile.
OPENVX_FEATURES: >-
-DOPENVX_CONFORMANCE_VISION=ON
-DOPENVX_USE_ENHANCED_VISION=ON
Expand Down Expand Up @@ -61,7 +59,6 @@ jobs:
-DCMAKE_INSTALL_PREFIX="$OPENVX_DIR" \
-DCMAKE_INSTALL_BINDIR=bin -DCMAKE_INSTALL_LIBDIR=bin \
-DBUILD_X64=1 \
-DCMAKE_CXX_FLAGS="-include limits" \
$OPENVX_FEATURES
make install -j$(nproc)
- name: Build Conformance Test Suite
Expand Down Expand Up @@ -109,7 +106,6 @@ jobs:
-DCMAKE_INSTALL_PREFIX="${{ github.workspace }}/install/Linux/x64/Release" \
-DCMAKE_INSTALL_BINDIR=bin -DCMAKE_INSTALL_LIBDIR=bin \
-DBUILD_X64=1 \
-DCMAKE_CXX_FLAGS="-include limits" \
$OPENVX_FEATURES
make install -j$(nproc)
- name: Upload Release install artifact
Expand Down
4 changes: 4 additions & 0 deletions kernels/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ FIND_SOURCES()
file(GLOB OVX_SRC_NNEF_LIB "${CMAKE_SOURCE_DIR}/kernels/NNEF-Tools/parser/cpp/src/*.cpp")
add_library (${TARGET_NAME} STATIC ${OVX_SRC_NNEF_LIB} )

# NNEF-Tools uses std::numeric_limits without #include <limits>; modern GCC
# no longer pulls it in transitively, so force-include it for this target.
target_compile_options(${TARGET_NAME} PRIVATE -include limits)

install ( TARGETS ${TARGET_NAME}
RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
Expand Down
Loading