Fix std::numeric_limits missing include for NNEF-Tools target#71
Merged
Conversation
Add target_compile_options(-include limits) scoped to the nnef-lib target in kernels/CMakeLists.txt. Modern GCC no longer pulls in <limits> transitively, causing build failures without an explicit workaround. Scoping the fix to the target avoids polluting the global CMAKE_CXX_FLAGS and removes the need for downstream consumers to work around it. Remove the corresponding workaround from ci.yml. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernels/NNEF-Toolsusesstd::numeric_limitswithout#include <limits>; modern GCC no longer pulls it in transitively, causing build failures-DCMAKE_CXX_FLAGS="-include limits"globally in CI, which pollutes all targets and requires every downstream consumer to apply the same workaroundtarget_compile_options(nnef-lib PRIVATE -include limits)inkernels/CMakeLists.txt, scoped only to the affected target-DCMAKE_CXX_FLAGS="-include limits"workaround fromci.yml(both Debug and Release build jobs)Test plan
-DOPENVX_CONFORMANCE_NNEF_IMPORT=ON— should compile without-DCMAKE_CXX_FLAGS="-include limits"🤖 Generated with Claude Code