Skip to content

Use the cached task-local SYCL queue for oneMKL FFT plans #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michel2323 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Draft

Use the cached task-local SYCL queue for oneMKL FFT plans #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/mkl/fft.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,13 @@ function _create_descriptor(sz::NTuple{N,Int}, T::Type, complex::Bool) where {N}
desc = desc_ref[]
# Do not program descriptor scaling; we'll perform inverse normalization manually.
# Set placement explicitly based on plan type later
# Construct a SYCL queue from current Level Zero context/device (reuse global queue)
# Use the task-local cached SYCL queue wrapping the global Level Zero queue, like the
# other oneMKL wrappers do. Creating fresh syclContext/syclQueue objects per plan is
# unsound: once they become garbage their finalizers (syclQueueDestroy etc.) tear down
# SYCL runtime state for the still-in-use underlying queue, corrupting later DFT
# commits and crashing at process exit.
ze_ctx = oneAPI.context(); ze_dev = oneAPI.device()
sycl_dev = SYCL.syclDevice(SYCL.syclPlatform(oneAPI.driver()), ze_dev)
sycl_ctx = SYCL.syclContext([sycl_dev], ze_ctx)
q = SYCL.syclQueue(sycl_ctx, sycl_dev, oneAPI.global_queue(ze_ctx, ze_dev))
q = oneAPI.sycl_queue(oneAPI.global_queue(ze_ctx, ze_dev))
return desc, q
end

Expand Down
Loading