Use the cached task-local SYCL queue for oneMKL FFT plans#586
Draft
michel2323 wants to merge 1 commit into
Draft
Use the cached task-local SYCL queue for oneMKL FFT plans#586michel2323 wants to merge 1 commit into
michel2323 wants to merge 1 commit into
Conversation
`_create_descriptor` built fresh syclDevice/syclContext/syclQueue objects for every FFT plan. Once those wrappers become garbage their finalizers (syclQueueDestroy etc.) tear down SYCL runtime state for the still-in-use underlying Level Zero queue, corrupting later DFT commits and crashing at process exit. Use the cached task-local `sycl_queue(global_queue(...))` accessor that every other oneMKL wrapper already uses, so the plan shares the managed queue lifetime instead of owning a throwaway one. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 80.92% 80.87% -0.05%
==========================================
Files 48 48
Lines 3234 3232 -2
==========================================
- Hits 2617 2614 -3
- Misses 617 618 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_create_descriptorbuilt freshsyclDevice/syclContext/syclQueueobjects for every FFT plan. Once those wrappers become garbage, their finalizers (syclQueueDestroyetc.) tear down SYCL runtime state for the still-in-use underlying Level Zero queue, corrupting later DFT commits and crashing at process exit.This switches
_create_descriptorto the cached task-localsycl_queue(global_queue(...))accessor that every other oneMKL wrapper (BLAS/LAPACK/sparse) already uses, so the plan shares the managed queue lifetime instead of owning a throwaway one.Notes
Touches only the queue construction in
_create_descriptor. TheGC.@preserverooting oflengths/stridesalready present onmain(#582) is left untouched.🤖 Generated with Claude Code