fix: expand adapters patch to fix more PerFrameFunctionalGroupsSequence crashes - #145
Merged
Merged
Conversation
…ce crashes Adds null checks and optional chaining for PerFrameFunctionalGroupsSequence in: - insertPixelDataPlanar (lines 555, 557, 558, 568) - insertOverlappingPixelDataPlanar (line 821) - getSegmentData (lines 914, 926, 929) Fixes "Cannot read properties of undefined (reading 'length')" errors when loading SEG files without PerFrameFunctionalGroupsSequence.
igoroctaviano
requested a deployment
to
fork-pr-approval
October 5, 2026 19:35 — with 
GitHub Actions
Queued
GitHub Actions
Queued
This branch is being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the
@cornerstonejs/adapterspatch to fix additional crash locations whenPerFrameFunctionalGroupsSequenceis undefined.Problem
After fixing
checkOrientation, there were more crashes inlabelmapImagesFromBuffer.js:insertPixelDataPlanar- lines 555, 557, 558, 568insertOverlappingPixelDataPlanar- line 821getSegmentData- lines 914, 926, 929All crash with "Cannot read properties of undefined (reading 'length')" or similar.
Solution
Added optional chaining (
?.) and null checks throughout these functions.Upstream Issue
cornerstonejs/cornerstone3D#2962
Test plan