Skip to content

fix: patch checkOrientation to handle missing PerFrameFunctionalGroupsSequence #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 1 commit into from
Oct 5, 2026
Merged

fix: patch checkOrientation to handle missing PerFrameFunctionalGroupsSequence #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions patches/@cornerstonejs__adapters.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
diff --git a/dist/esm/adapters/helpers/checkOrientation.js b/dist/esm/adapters/helpers/checkOrientation.js
index f147ce19972dfe2f30ed820509943bb2ab2f34d0..47868b5ae063ee61e4061aa46ef5ccf49692fb34 100644
--- a/dist/esm/adapters/helpers/checkOrientation.js
+++ b/dist/esm/adapters/helpers/checkOrientation.js
@@ -4,9 +4,20 @@ import { utilities } from '@cornerstonejs/core';
function checkOrientation(multiframe, validOrientations, sourceDataDimensions, tolerance) {
const SharedFunctionalGroupsSequence = multiframe.SharedFunctionalGroupsSequence,
PerFrameFunctionalGroupsSequence = multiframe.PerFrameFunctionalGroupsSequence;
- const sharedImageOrientationPatient = SharedFunctionalGroupsSequence.PlaneOrientationSequence ? SharedFunctionalGroupsSequence.PlaneOrientationSequence.ImageOrientationPatient : undefined;
- const PerFrameFunctionalGroups = PerFrameFunctionalGroupsSequence[0];
- const iopRaw = sharedImageOrientationPatient || PerFrameFunctionalGroups.PlaneOrientationSequence.ImageOrientationPatient;
+ const sharedImageOrientationPatient = SharedFunctionalGroupsSequence?.PlaneOrientationSequence ? SharedFunctionalGroupsSequence.PlaneOrientationSequence.ImageOrientationPatient : undefined;
+
+ /** Get orientation from per-frame if shared doesn't have it and per-frame exists */
+ let iopRaw = sharedImageOrientationPatient;
+ if (!iopRaw && PerFrameFunctionalGroupsSequence && PerFrameFunctionalGroupsSequence.length > 0) {
+ const PerFrameFunctionalGroups = PerFrameFunctionalGroupsSequence[0];
+ iopRaw = PerFrameFunctionalGroups?.PlaneOrientationSequence?.ImageOrientationPatient;
+ }
+
+ if (!iopRaw) {
+ /** No orientation found, default to Planar to avoid throwing */
+ return 'Planar';
+ }
+
const iop = Array.isArray(iopRaw) ? iopRaw.map(Number) : iopRaw;
const inPlane = validOrientations.some(operation => utilities.isEqual(iop, operation, tolerance));
if (inPlane) {
11 changes: 6 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,5 @@ overrides:
'browserslist@<4.28.7': 4.28.8
'image-size@>=0.6.3 <2.0.4': 2.0.4
patchedDependencies:
'@cornerstonejs/adapters': patches/@cornerstonejs__adapters.patch
'@cornerstonejs/core': patches/@cornerstonejs__core.patch
Loading