fix: patch checkOrientation to handle missing PerFrameFunctionalGroupsSequence - #144
Merged
Merged
Conversation
…sSequence The checkOrientation function in @cornerstonejs/adapters would crash with "Cannot read properties of undefined (reading '0')" when loading SEG files where PerFrameFunctionalGroupsSequence is undefined or empty. The fix: - Adds optional chaining for SharedFunctionalGroupsSequence - Only accesses PerFrameFunctionalGroupsSequence if it exists and has items - Falls back to 'Planar' if no orientation data is found
igoroctaviano
had a problem deploying
to
fork-pr-approval
October 5, 2026 16:45 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@cornerstonejs/adaptersto fix SEG loading crashcheckOrientationProblem
The
checkOrientationfunction crashes when loading SEG files wherePerFrameFunctionalGroupsSequenceis undefined or empty. The function was accessingPerFrameFunctionalGroupsSequence[0]without checking if the array exists.Solution
The patch:
SharedFunctionalGroupsSequencePerFrameFunctionalGroupsSequenceif it exists and has items'Planar'if no orientation data is foundUpstream Issue
cornerstonejs/cornerstone3D#2962
Test plan