Show -- when PWR is 0, retain last position data, merge RSSI 1 / 2 in to single row and add RSNR when in non FLRC mode

[jurgelenas]

Addresses

Telem Widget - PWR reads 0 mW when not connected but others show --
Telem Widget - No last GPS position on disconnect? If not in your
design plans that's fine, something for later.
Telem Widget - Fullscreen - Maybe merge RSSI 1 / RSSI 2 onto one line
so the RSNR can be added?

[CapnBry]

The changes I requested look perfect! However, while testing this I encountered a new issue.

The "Active Antenna" field in the fullscreen basically shows ANT + 1. Someone thought it was a good idea to change EdgeTX so that in an upcoming version, the ANT field coming from ExpressLRS already gets 1 added to it. This creates a problem not just for the fullscreen, but the non-fullscreen ui as well that adds 1 to it, and also the activeRssi() value relies in ANT being 0-1 as well.

Iiiiiii am not sure how to fix this because 0-1 is indistinguishable from 1-2 to the lua script. I feel like maybe this issue alone might be worth considering going to EdgeTX and revert this change? @mha1 What do you suggest as a resolution to the antenna change breaking every Lua script that tries to display the antenna / select which RSSI is active?

EDIT: I suppose we could go by EdgeTX version setting a global constant in our lua that sets the base antenna value as 0 or 1? haha Such a small little quality of life change (make antenna number match 1 / 2 elsewhere) now needing workarounds that will be in the code for years.

[mha1]

ExpressLRS/ExpressLRS#3734

I pointed out the inconsistency between ELRS and EdgeTX and honestly thought it'd be better to make our side consistently using the 0-based naming. Management decided 1-based, so I offered to put in an EdgeTX PR displaying and logging 1-based too.

Options (unsorted)

• version checked 0 or 1 based interpretation in Lua scripts
• live with the inconsistency
• revert the ETX change and also live with the inconsistency
• change our side to a 0-based naming and revert the ETX change

My vote is on the last bullet point

[mha1]

"Lua script that tries to display the antenna / select which RSSI is active?"

Not very useful, at least for true diversity receivers, isn't it?

[CapnBry]

Not very useful, at least for true diversity receivers, isn't it?

I think everything is still sort of working off the system where only one number needs to be shown and they want to pick one.

But anyway I shouldn't hold this up because we need to figure out how to work around this at the larger level and for now this uses the correct way.