New LUA scripts & widgets

[jurgelenas]

No description provided.

[CapnBry]

Whew. A lot to get through but almost all these are small tweaks. I really like the visual redo you did on the VTX Admin, it looks great and the widget is a lot easier to glance at now. This took the better part of 2 days to get through all the code again with so many different scripts on so many platforms, but here's the abridged review notes!

• Deleting elrs.lua? Why did we add it to this repo if it wasn't going to live here? I'm fine with however we think we should handle it but this is the Lua repo so I think we should move it to a legacy folder, merge the main repo's version in here, remove it from the main repo. For this PR I'd just leave it where it is currently and then a separate PR to deal with it.
• Remove edgetx-lua-stdlib
• Bind Tool - UID_MAX_ATTEMPTS is too low, I got MANY "no response" while the module rebooted. Maybe 10-12 instead of 6?
• B&W Bind - Title should be "ExpressLRS Bind" and version number goes in the EXIT string for consistency with main tools lua (use same format too?)
• Why do the B&W tools scripts require an EdgeTX version? Isn't the version gating just for proper lvgl support?
• "alert" is the same thing as "dialog" except one is B&W and the other is lvgl. Should they be named the same?
• Why aren't the version and nomodule messages in alert instead of multiple copies in the UI? Telemtry/VTX admin widgets fullscreen UI also duplicates the nomodule message.
• The Dialogs.showNoModule minumum bauds are incorrect. These are suggested bauds. Also Baud should not be caps. It also does not include the bit about setting the "internal RF type" in sys either and perhaps F1000 should be 1000Hz because there are many 1000Hz modes.
• TextEdit - No way to select next character or back up?

  if event == EVT_VIRTUAL_PREV_PAGE then
    self.cur = math.max(self.cur - 1, 1)
  elseif event == EVT_VIRTUAL_NEXT_PAGE then
    self.cur = math.min(self.cur + 1, math.min(self.maxLen, #self.value + 1))
  end
  

• TextEdit - Maybe also move the things that return true to the top and everything else that returns nil just fall through to the return nil? Also return nil is unneeded
• VTX Admin top bar UI - Can it look more like a "Value" type builtin widget? Same font sizes as the builtin does, with small "VTX" and large band/channel, left aligned to match the same visual style
• Telem Widget - Align values vertically for PWR/BATT and TQly/TRSS.
• Telem Widget - PWR reads 0 mW when not connected but others show --
• Telem Widget - No last GPS position on disconnect? If not in your design plans that's fine, something for later.
• Telem Widget - Fullscreen - Maybe merge RSSI 1 / RSSI 2 onto one line so the RSNR can be added?
• Telem Widget - 1x4 layout TX16S with all EdgeTX bars (trim, pots, etc) still on, LQ wraps to 2 lines? Honestly it is impressive that this is the only visual glitch I ran into when testing every shape. I bet this was a ton of work to make each one look right!

AIness

• README.md is loaded with AI bloat about directory structure. This is user-facing documentation and this does not help the user. I mean this whole thing is bloated with describing what every button does and what screen resolutions are supported by one widget and bullshit like that. Please just do this by hand and don't ask AI to do it. I can also do it if you'd prefer
  • ExpressLRS Lua Scripts - I think we can change this to just one line about what the repo is. No need to list the things that are in it, they are listed below
  • Features - remove
  • Installation section - First line is good, the full directory structure needs to go
  • Section for each tool / widget is good, but remove all the AI explanation of how it works, just a single sentence about what each thing is and screenshots are good
  • Compatibility. Good, but the bit about the bind manager "The bind phrase manager additionally requires ExpressLRS 4.1+" (delete the rest)
• You gotta get stop letting the AI generate novels about everything, Like what is all the garbage at the top of every file that instead of just saying what the file is, it goes on about minor architecture features it seems to be proud of. Even the function comments read like a 4 year old who just read a book on design patterns and obfuscate the meaning. Comments are only supposed to say as much as they need to, not describe the history of code. Sometimes it wants to add the license, sometimes it wants to tell you what EdgeTX version was important when the header was added but is no longer correct, sometimes it goes on rambling story. You don't have to change these but in the future please try to reduce comments to only meaningful important things that aren't obvious.

ELRS Version requirement

We know what the ELRS version is from the deviceinfo header, and we know what version the script requires, but these scripts just sort of fail to work properly if the ELRS version isn't high enough. It could display a message about it.

*** DO NOT MAKE THAT CHANGE, I DO NOT WANT TO REVIEW NEW FEATURE CODE AGAIN *** this could be done in a separate PR if you want. Somebody should though.

[jurgelenas]

Deleting elrs.lua? Why did we add it to this repo if it wasn't going to live here? I'm fine with however we think we should handle it but this is the Lua repo so I think we should move it to a legacy folder, merge the main repo's version in here, remove it from the main repo. For this PR I'd just leave it where it is currently and then a separate PR to deal with it.

Addressed in #23

Remove edgetx-lua-stdlib

I was hoping for EdgeTX team to release official EdgeTX Lua typedefs based on my https://github.com/jurgelenas/edgetx-lua-stdlib idea. Unfortunately the progress has stalled. Will remove it later.

Bind Tool - UID_MAX_ATTEMPTS is too low, I got MANY "no response" while the module rebooted. Maybe 10-12 instead of 6?

Addressed in #25

B&W Bind - Title should be "ExpressLRS Bind" and version number goes in the EXIT string for consistency with main tools lua (use same format too?)

Addressed in #26

Why do the B&W tools scripts require an EdgeTX version? Isn't the version gating just for proper lvgl support?

I think I had more reasons for it, but the only thing that I can remember now is that we are using directories for tool scripts.

"alert" is the same thing as "dialog" except one is B&W and the other is lvgl. Should they be named the same?
Why aren't the version and nomodule messages in alert instead of multiple copies in the UI? Telemtry/VTX admin widgets fullscreen UI also duplicates the nomodule message.
The Dialogs.showNoModule minumum bauds are incorrect. These are suggested bauds. Also Baud should not be caps. It also does not include the bit about setting the "internal RF type" in sys either and perhaps F1000 should be 1000Hz because there are many 1000Hz modes.

Addressed in #27

TextEdit - No way to select next character or back up?
if event == EVT_VIRTUAL_PREV_PAGE then
self.cur = math.max(self.cur - 1, 1)
elseif event == EVT_VIRTUAL_NEXT_PAGE then
self.cur = math.min(self.cur + 1, math.min(self.maxLen, #self.value + 1))
end
TextEdit - Maybe also move the things that return true to the top and everything else that returns nil just fall through to the return nil? Also return nil is unneeded

Addressed in #28

VTX Admin top bar UI - Can it look more like a "Value" type builtin widget? Same font sizes as the builtin does, with small "VTX" and large band/channel, left aligned to match the same visual style

Good idea. I have updated telemetry widget top bar layout too.

Addressed in #29

Telem Widget - Align values vertically for PWR/BATT and TQly/TRSS.

Addressed in #30

Telem Widget - PWR reads 0 mW when not connected but others show --
Telem Widget - No last GPS position on disconnect? If not in your design plans that's fine, something for later.
Telem Widget - Fullscreen - Maybe merge RSSI 1 / RSSI 2 onto one line so the RSNR can be added?

Addressed in #31

Telem Widget - 1x4 layout TX16S with all EdgeTX bars (trim, pots, etc) still on, LQ wraps to 2 lines? Honestly it is impressive that this is the only visual glitch I ran into when testing every shape. I bet this was a ton of work to make each one look right!

Could not reproduce this one. Could you share a screenshot? What EdgetTX version you were using?

[CapnBry]

Could not reproduce this one. Could you share a screenshot? What EdgetTX version you were using?

This is my bad bug reporting to blame. I meant to type 2x4 layout not 1x4 layout.