fix(sqlite-do): support nested storage transactions - #8267
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: deb174c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support nested
withTransactioncalls in@effect/sql-sqlite-dothrough nestedDurableObjectStorage.transaction()callbacks. Children reuse the active connection with an incremented transaction depth; only the outer transaction takes the semaphore.Effect failures call
txn.rollback()and resolve the storage callback, allowing caught child failures and interruptions to roll back independently. Includes module documentation and a patch changeset. Concurrent siblings remain unsupported.Reject cross-client
withTransactioncalls before opening storage or running the body. Credit to danieljvdm for this guard, ported from #8258. The guard coverswithTransaction; it does not fix the existing cross-client plain-query routing issue.Tests were added and verified failing in separate runs before implementation. Implementation commits make no test changes.
Validation
nix develop -c pnpm test --run packages/sql/sqlite-do/test/Client.test.ts: all 14 tests pass, including the cross-client regression.nix develop -c pnpm check: passed.nix develop -c pnpm lint-fixandnix develop -c pnpm lint: passed.git diff --check: passed.nix develop -c pnpm jsdocs --checkrun reported two existing formatting diagnostics in unchangedpackages/effect/src/unstable/ai/McpSchema.ts(short description must be one paragraph; description content must appear under a standard section heading).Closes EFF-1390