Conversation
🦋 Changeset detectedLatest commit: 183c2bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
An automatic yield inside
withTransactioncan wait on a scheduler timer queued before the transaction began. That timer is blocked by the transaction's input gate, so workerd resets the DO after the 30-secondblockConcurrencyWhile()timeout.Minimal reproduction
Inside a scoped
Effect.genin a Durable Object request, with a storage-backedsqlclient provided bySqliteClient.layer({ storage: ctx.storage }):The fork queues an outside timer; the transaction's yield waits for that timer while holding the input gate. This hits the 30-second timeout on the base implementation and completes with the fix. The explicit yield makes the trigger deterministic; automatic scheduler yields can cause the same deadlock.
Run each transaction body and its native-completion finalizer with a fresh microtask scheduler to break this cycle. Restore the caller's scheduler afterward.
Adds workerd regressions for commit, nested commit, and rollback with an outside fiber queued. All three reproduce the timeout on the base implementation and pass with the fix.
Related