Repository navigation
The compositor configuration's, the zone-border patch's and the chrome's comments are shorter, with their reasons kept - #254
Merged
Conversation
…e's comments are shorter, with their reasons kept: cleanup-held's cut of dwl-config.h, dwl-zone-borders.py, kryptik-chrome and docs/architecture.md, redone on main by hand, comments only Only comment regions are taken from 65a6fbb, and the patch script's edit comments lose their numbers, all eight. Main's text stays where the cut drops a reason the chrome and compositor rely on: the border colour comes from the app_id prefix only the proxy stamps; passphrases reach the daemon as a descriptor, never argv or the environment; the consent window drops keys because a hostile zone's may be waiting; the watcher's lock goes with its subshell and a second watcher leaves. architecture.md keeps main's fullscreen bar, which the cut predates.
… an answer that cannot be written is safe From a non-author read: the cut lost that consent.rs refuses at once if it can take watcher.lock shared, and that an unwritten answer is a refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the cleanup-held redo, after #241-#248 and #252: the files #191 held. Comments only in
build/desktop/dwl-config.h,tools/desktop/dwl-zone-borders.pyandtools/desktop/kryptik-chrome, and prose indocs/architecture.md.gui-check.sh,wlprobe.candgui-test.shwait for #253, which changes them.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment were kept. Each cut was then read by hand. Stripping comments from main's version and this one gives the same code in all three files.
sh -npasses on the chrome, and the patch script still parses. Every changed line indwl-zone-borders.pyis a Python comment between edits, never text inside the C it writes into dwl.c.Kept from the cut: the patch script's edit comments without their numbers (
(1)to(8); the cut dropped six, and this drops the other two). The chrome's notes on the zone files, havoc's arguments, the focus.zone record,--ask, the clock question and the code's three comments. architecture.md's broker paragraph in shorter sentences, and one rewrap.Kept from main, or rewritten to keep a reason the cut dropped:
kryptik.<zone>.app_id prefix the proxy stamps, and focus never changes it. The commands comment keeps why the menu runs in havoc (a text program in a zone 0 terminal of its own).--promptis where kryptik-launch hands over when it has no terminal. Passphrases reach the daemon as a descriptor, never argv or the environment, and the prompt's comment says so again.set -Cmeans writes never follow a link, not only never clobber.Dropped from the cut: both of architecture.md's conflicting passages, where main now describes #191's fullscreen bar. "Only the user, with a watch, can say."
How the run proves it. CI's compositor tests build the patched dwl and the fixture suites run the chrome's helpers. Nothing else changes.