Repository navigation
The desktop suite's guest checks and its probe have shorter comments, with their reasons kept - #259
Merged
Merged
Conversation
… with their reasons kept: cleanup-held's cut of gui-check.sh and wlprobe.c, redone on main by hand, comments only The oversize section keeps why the excess lies under the right and bottom borders (dwl clips to (w - bw) x (h - bw)), and wlprobe's header what it shows in a zone and in zone 0; gui-test.sh's header is its --help and stays.
…al's terminal up, why interpreters and havoc are judged by what they run, and that no zone can read the consent code's file From a non-author read: zone-app-in-cgroup passes only while personal's havoc runs, and the case arms judge bash, python3 and havoc by their first argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the cleanup-held redo, after #254: the desktop suite's guest checks and its probe, held until #253 landed. Comments only, in
build/guest-tests/gui-check.shandtools/desktop/wlprobe.c.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main 5990a42, and only regions where every changed line is a comment were kept. Each cut was then read by hand. Stripping comments from main's version and this one gives the same code in both files, and
bash -npasses on the check.Kept from the cut. Shorter comments in gui-check.sh:
casebeneath it),Section rules are evened to one width. In wlprobe.c: the wire format's path is now exact (
compositor/wlproxy/src/wire.rs), and the object ids,hold_oversizeand the guessed global name are shorter.Kept from main:
tools/image/gui-test.sh: its header is its--help(sed -n '2,20p'), and the cut's one-line header would lose the suite's charter and shift that range.Dropped from the cut: its conflicting hunks, which main has rewritten since (#191, #253).
How the run proves it. CI's compositor tests compile wlprobe.c, and shell lint covers the check. Nothing else changes.