Repository navigation
The zones suite's comments are shorter, with their reasons kept - #252
Merged
Merged
Conversation
…nup-held's cut of tools/image/zones-test.sh, redone on main by hand, comments only Three comments are taken from 65a6fbb: the 3 GB guest, the console copy of each suite's result, and the accepted launcher gaps, whose reasons the pass message beside them already names. The header stays main's, since --help prints lines 2-15 of it; the cut's mapper check conflicted with main's and is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the cleanup-held redo, after #241-#248. Comments only, in
tools/image/zones-test.sh, a file that open PRs had held until the last batch.How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment were kept. Each cut was then read by hand. Stripping comments from main's version and this one gives the same code, and
bash -npasses.Kept from the cut:
Kept from main:
--helpprints. The cut's one-line header loses the suite's charter, and both its header and its step 3 rewrap would change the line count thatsed -n '2,15p'relies on.#245. f6's #245 changes only this file's verdict-list line (adding
dhcpcd-separated), which this PR does not touch. f6 asked for this to land first.How the run proves it. CI's shell lint covers the file. Nothing else changes.