Skip to content

The zones suite's comments are shorter, with their reasons kept - #252

Merged
DevomB merged 1 commit into
mainfrom
comments-zones-suite
Oct 9, 2026
Merged

DevomB merged 1 commit into
mainfrom
comments-zones-suite

Conversation

@DevomB

@DevomB DevomB commented Oct 7, 2026

Copy link
Copy Markdown
Owner

Part of the cleanup-held redo, after #241-#248. Comments only, in tools/image/zones-test.sh, a file that open PRs had held until the last batch.

How it was done. The same procedure as #242. Cleanup-held's change was merged onto main, and only regions where every changed line is a comment were kept. Each cut was then read by hand. Stripping comments from main's version and this one gives the same code, and bash -n passes.

Kept from the cut:

  • The 3 GB guest: "not the default 2" becomes "not 2", with the reason (ephemeral-size-bound fills untrusted's 2G tmpfs, which is RAM) kept.
  • Step 3's console copy: the guest's disk is not kept, so each suite's exit code, summary tail and FAIL rows go to the console.
  • The accepted launcher gaps: the comment says only the gaps named below are accepted. Each one's reason (NETR, LC15/16, H1c) is in the pass message beside it, word for word.

Kept from main:

  • The header and step list, lines 2-15, which --help prints. The cut's one-line header loses the suite's charter, and both its header and its step 3 rewrap would change the line count that sed -n '2,15p' relies on.
  • The final mapper check, where the cut conflicted with main's newer check.

#245. f6's #245 changes only this file's verdict-list line (adding dhcpcd-separated), which this PR does not touch. f6 asked for this to land first.

How the run proves it. CI's shell lint covers the file. Nothing else changes.

…nup-held's cut of tools/image/zones-test.sh, redone on main by hand, comments only

Three comments are taken from 65a6fbb: the 3 GB guest, the console copy of
each suite's result, and the accepted launcher gaps, whose reasons the pass
message beside them already names. The header stays main's, since --help
prints lines 2-15 of it; the cut's mapper check conflicted with main's and is
dropped.
@DevomB
DevomB merged commit cdcd168 into main Oct 9, 2026
11 checks passed
@DevomB
DevomB deleted the comments-zones-suite branch October 9, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant