Repository navigation
The status page says stage 06 fails the build on a setuid bit or file capability its allowlists do not justify - #249
Merged
Merged
Conversation
… capability its allowlists do not justify: it has since c431bf4, and the page still said the stage strips them Stage 06 runs tools/audit-setuid.sh without --strip, which fails on an unlisted bit or capability (docs/hardening.md, "setuid elimination"); --strip is only for a root staged by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong.
docs/status.md's stage 06 row said the stage strips every setuid bit the allowlist does not justify. Since c431bf4, stage 06 runstools/audit-setuid.shwithout--strip(build/stages/06-iso.sh:146), so an unlisted setuid or setgid bit, or an unlisted file capability, fails the build.--stripis only for a root staged by hand, asdocs/hardening.md("setuid elimination") already says.What changed. That one sentence of the row now says the stage fails the build on any setuid bit or file capability its allowlists do not justify.
How the run proves it. This is docs only, and no script reads the row. #245 also edits
docs/status.md, but sixty lines further down, so the two merge cleanly in either order.