Fix irregular whitespace for MetadataRepresentationListComponent

[alexandrevryghem]

Description

Removed the trailing whitespace below the MetadataRepresentationListComponent when the page size is smaller than 10. Also reduced the spacing below the load more/hide last buttons to match the default spacing between item page fields.

Instructions for Reviewers

List of changes in this PR:

• Hide the mt-2 spacing from the load more/hide last buttons when the page size is smaller than 10
• Replaced the float-start & float-end styling on the load more/hide last buttons with flex box with justify-content: between. This will remove the additional spacing generated by the float logic underneath the buttons.
• Made the separator for this item page field configurable as well

Guidance for how to test and review this PR:

• Create a publication with 1 author
  • Verify that the spacing between the authors field & the next field is now the same as the other fields:
    →
• Create a publication with 10+ authors
  • Verify that the spacing between the authors field & the next field is now the same as the other fields:
    →

Checklist

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[nathanmlf]

Hey @alexandrevryghem! I've tested it on my side and everything seems to be working as expected. I will attach some screenshots below for comparison:

One author test (Sandbox):

One author test (PR-5665):

Ten authors test (Sandbox):

Ten authors test (PR-5665):

Nice job with the improvement!

[tdonohue]

@alexandrevryghem : I'm finding that this PR fixes some things, but makes other displays slightly worse??

For example, here's what I see for the same Publication on http://sandbox.dspace.org (without this PR), and on my local machine (with this PR) and on my local machine without this PR.

The Sandbox display looks the best. The behavior with this PR looks decent, but doesn't work if an author has an ORCID next to it. If I remove your PR from my local machine, then authors are jumbled (which doesn't look great either). I'm trying to figure out why I'm seeing three different displays, but it must be based on which features are enabled.

Sandbox display: (See https://sandbox.dspace.org/entities/publication/f3edcd34-ed72-43eb-9594-77c206636540)

This PR's display:

My local machine without this PR:

Overall, this PR seems like it's an improvement, but it's a bit buggy if the authors have an ORCID identifier.

Finally, I did want to note that this PR seems to be a fix for #5519 (which is the bug you see in my local display above) and therefore seems to have an overlap with #5540

[alexandrevryghem]

@tdonohue: Thnx for the review! Sorry about that PR conflict I didn't know an issue was already submitted for that 😬. I fixed the issue you mentioned, I also noticed that the project items like this one had the same issue for the Contributors field and this fix now fixes it for both.

NOTE: to easily test it I updated the metadataFields mapping locally to this (in my project.component.html):

<ds-metadata-representation-list
  [parentItem]="object"
  [itemType]="'OrgUnit'"
  [metadataFields]="['project.contributor.other', 'dc.contributor.other']"
  [label]="'project.page.contributor' | translate">
</ds-metadata-representation-list>

[tdonohue]

👍 Thanks @alexandrevryghem ! This now works well. The prior issues have been corrected. Code looks good too.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5665-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5665-to-dspace-7_x
git switch --create backport-5665-to-dspace-7_x
git cherry-pick -x 7d1341e4d2a3f03d8515bce1f289c64506a23ec3

[dspace-bot]

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-5665-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-5665-to-dspace-8_x
git switch --create backport-5665-to-dspace-8_x
git cherry-pick -x 7d1341e4d2a3f03d8515bce1f289c64506a23ec3

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] Fix irregular whitespace for MetadataRepresentationListComponent #5722

[tdonohue]

@alexandrevryghem : This was only able to be backported automatically to 9.x. But, then again, I've only seen this misalignment in more recent versions, so I'm not confident this same bug exists in 8.x or 7.6.x. Nonetheless, if you want to backport it further, please create separate PR(s) against those branches.

[tdonohue]

@alexandrevryghem : I just noticed that after merging this PR, the "startsWith" links on Authors has been removed from the Sandbox site.

For instance, take a look at this same Item on the Sandbox vs the Demo site:

• https://sandbox.dspace.org/handle/123456789/233
• https://demo.dspace.org/handle/123456789/233

On the Demo site, all authors are hyperlinked, and point at the "Browse by Author" link for that author.
On the Sandbox site, those same hyperlinks used to be there (see my screenshot above) until I merged this PR.

Maybe this was a small bug introduced by this PR?

(I haven't merged #5722 yet, which is the backport of this PR for dspace-9_x. But, I suspect it will result in the same behavior on the Demo site)

[alexandrevryghem]

@tdonohue: This PR didn't introduce any Typescript changes, only layout changes, so that bug is unrelated. I tested PR #5722 locally against https://demo.dspace.org as well and all the authors are still rendering as browse links so this is a separate bug or the servers might be configured differently 🤔

[alexandrevryghem]

@tdonohue: I traced this change back to PR #4956 which replaced the PlainTextMetadataListElementComponent for metadata values with an authority key with the new AuthorityLinkMetadataListElementComponent. Because on DSpace 10 all fields automatically get an authority ID the AuthorityLinkMetadataListElementComponent will now always be used for dc.contributor.author as long as it stays authority controlled

[tdonohue]

@alexandrevryghem : Thanks for your investigatory work! I was a bit confused about what the cause was, but good to understand it wasn't this refactor. I must have been mistaken then that this behavior changed on Sandbox after this PR was merged. I can always log a separate bug for this issue.

In any case, I'll merge the 9.x version of this PR now. #5722