Fix #5519: Authors with invalid Authority entries not displayed properly

[guillermo-escire]

References

Fixes #5519

Description

Authors with invalid Authority entries were appearing smashed together on Item pages. This fix ensures proper separation between authors regardless of whether they have a valid or invalid Authority value.

Instructions for Reviewers

Instructions for Reviewers
List of changes in this PR:

• metadata-representation-list.component.html — Added separator
  between each ds-metadata-representation-loader in the @for loop so authors are always visually separated.
• metadata-link-view.component.ts — Changed entityType: 'PRIVATE' to entityType: null in the else branch of createMetadataView, so authors with an invalid authority are rendered as plain text instead of triggering the textWithIcon template.
• metadata-link-view.component.html — Moved d-inline-block div inside the @if (metadataView) block so no empty div is rendered when metadataView is null.
• metadata-link-view.component.spec.ts — Updated existing test when item is not found to expect textWithoutIcon instead of textWithIcon, reflecting the corrected behavior.
• metadata-representation-list.component.spec.ts — Added test to verify that separators are rendered between ds-metadata-representation-loader components.

How to test:

1. Find an Item with multiple authors in dc.contributor.author
2. Go to Administer → Metadata tab
3. Add a fake UUID like 94466ca9-b8d2-4c8e-9898-3ae87be9b116 in the Authority column for each author
4. Save and go back to the Item page
5. Authors should appear separated on individual lines, not smashed together

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[kanasznagyzoltan]

@guillermo-escire
We have tested this PR. For us works as intended. After giving the authors an invalid UUID, they still appear on separate lines and not being smashed together. We have created a video about it.

pr_5540.mp4

[GauravD2t]

An.evidence-based.algorithm.for.early.prognosis.of.severe.dengue.in.the.outpatient.setting.mp4

Thanks @guillermo-escire for the contribution! The video shows an extra newline causing a UI layout issue. Please correct this.
https://sandbox.dspace.org/entities/publication/an-evidence-based-algorithm-for-early-prognosis-of-severe-dengue-in-the-outpatient-setting

[github-actions]

Hi @guillermo-escire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[tdonohue]

Closing as this has been replaced by #5665 which happened to fix this issue along with some other related problems. Apologies for the overlapping PRs in this scenario. But, thanks @guillermo-escire for your contribution nonetheless.