feat(core): add bounded semantic node observation contract - #52
Draft
seonghobae wants to merge 19 commits into
Draft
feat(core): add bounded semantic node observation contract#52seonghobae wants to merge 19 commits into
seonghobae wants to merge 19 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28.
Buyer-visible gap
OriginWeave needs a bounded semantic observation contract between raw browser evidence and later typed policy/action logic. A semantic observation must preserve OriginWeave-owned node authority, bound attacker-controlled text and relationships, and identify how the observation was produced without turning page/tool metadata into instruction or execution authority.
This stacked lane remains based on exact PR #40 head
9e635e80e9813a1d2a9c408155d52221b76eeed3and therefore remains Draft while that prerequisite is active.TDD and RCA
The lane began with fail-first contracts for the base semantic observation primitive and later for explicit observation provenance. The latest relationship refinement was also test-first.
Exact test-only head
b1bd4f8bd3b5597dac8ad3c40530beba7288e8carequired:CI run
31414009540established the intended RED because the production fields, accessors, bound and errors did not yet exist. Production commits then implemented that boundary and applied only the canonical rustfmt delta surfaced by CI.Exact head
dbe75ca557fc6f501b0e54846c81dffa58812cedpassed ordinary contracts/tests/rustdoc but exact coverage found the remaining meaningful branch gap: the short-circuit authority comparison had exercised only the origin-mismatch axis. Production functions and lines were already 100%, while regions were5409/5417and branches516/520overall.Current exact head
94fd284fe41746eeba9edc05d9753903b1c41ebfadds focused regressions for independent browser-session, browsing-context, origin and document-epoch mismatches plus child-side mismatch propagation. No production logic was weakened to satisfy coverage.Current implemented boundary
SemanticNodeObservationnow:ObservedNodeHandlerather than a raw BiDi/CDP/renderer identifier;Accessibility, DOM, layout, structured data, WebMCP and visual content remain untrusted observations rather than policy/instruction authority. Relationship metadata cannot mint capability.
Exact-head evidence
On unchanged exact head
94fd284fe41746eeba9edc05d9753903b1c41ebf, stacked on exact prerequisite #40 head9e635e80e9813a1d2a9c408155d52221b76eeed3:31428454410: success;31428454350: success;No predecessor-head result is transferred to this exact head.
Scope boundary
This PR adds no browser I/O, Chromium/BiDi/CDP/WebMCP transport, raw HTML retention, unrestricted JavaScript execution, action dispatch, post-condition verification, persistence, secrets, network authority, model call, workflow mutation or release claim. It is an authority/provenance-bound semantic-observation value prerequisite for the first real Chromium vertical slice, not the browser observation adapter itself.
Canonical whole-product documentation remains owned by PR #44, which records #52 only as active/non-shipped evidence and does not invent a new service, physical ERD entity or Accepted ADR for this value primitive.
Dependency/governance
Keep Draft while prerequisite #40 remains active. This scheduled actor does not merge or self-approve. Any later head movement invalidates the exact-head evidence above and requires fresh validation.