feat(core): add typed semantic node query contract - #57
Draft
seonghobae wants to merge 7 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28.
Buyer-visible gap
The active semantic-observation lane provides bounded authority-scoped node evidence, but the first real Chromium vertical slice also needs a typed node-query primitive. Without one, later adapters would be tempted to expose arbitrary selector strings, raw DOM search, or model-generated script as the ordinary query contract.
Exact TDD evidence
This Draft remains stacked on exact PR #52 head
94fd284fe41746eeba9edc05d9753903b1c41ebf.The test-only head
d0cd133f5be62fff99612d5b08aa4cf08ce2f29festablished the intended RED in CI run31429065905: repository contracts and formatting passed, while the locked workspace check failed on the deliberately absent publicSemanticNodeQueryandSemanticNodeQueryErrorimports.The narrow production implementation now provides a public
SemanticNodeQuerythat:SemanticNodeObservationvalues rather than raw DOM/protocol identifiers; andA predecessor implementation head then exposed strict-Clippy
collapsible_iffailures. Current exact headb4fa49953cbbb21c879a3340e264a6e132e41634replaces those nested conditions with equivalent boundedOption::is_some_andchecks rather than weakening lint policy.Exact-head acceptance
On exact head
b4fa49953cbbb21c879a3340e264a6e132e41634:31429995885: success;31429997851: success;No predecessor-head result is transferred to this exact head.
Scope boundary
This lane adds no browser I/O, CSS/XPath selector language, raw DOM selector surface, arbitrary JavaScript, fuzzy/embedding/model search, action execution, capability grant, persistence, secrets, network authority, workflow mutation or release claim. Query success is descriptive matching only; it cannot authorize or execute an action.
Keep Draft while prerequisite #52/#40 remain active. Canonical whole-product documentation remains owned by PR #44 and tracks this lane only as active/non-shipped evidence.