feat: bound HTTP/1.1 semantics to authenticated streams - #11
feat: bound HTTP/1.1 semantics to authenticated streams#11seonghobae wants to merge 361 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthrough인증된 TLS 연결에서 단일 HTTP/1.1 ChangesHTTP/1.1 의미론
Estimated code review effort: 5 (Critical) | ~120 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant HttpExchangePlan
participant AuthenticatedTlsConnection
participant ResponseParser
participant ContentDecoder
participant Evidence
Caller->>HttpExchangePlan: 요청 및 정책으로 계획 생성
HttpExchangePlan->>AuthenticatedTlsConnection: peer·origin·ALPN 검증
HttpExchangePlan->>AuthenticatedTlsConnection: HTTP/1.1 요청 쓰기
AuthenticatedTlsConnection->>ResponseParser: 응답 헤드와 본문 전달
ResponseParser->>ContentDecoder: framing된 본문 디코딩
ContentDecoder->>Evidence: 콘텐츠·digest·MIME 결과 기록
Evidence-->>Caller: AuthenticatedHttpResponse 반환
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
left a comment
There was a problem hiding this comment.
Standards-conformance finding on exact head 9032b5f7aeaac2626be926a05ab0252f3e8ba06d: response_head::parse_status_line currently accepts HTTP/1.1 200 without the mandatory separator SP, while rejecting HTTP/1.1 200 when the reason phrase is absent. RFC 9112 §4 defines status-line = HTTP-version SP status-code SP [ reason-phrase ] and explicitly requires the server to send the separator SP even when the reason phrase is absent. Add the regression contract first (accept the empty reason phrase after the mandatory SP; reject a missing second SP), then adjust the parser. Keep strict CRLF and field parsing unchanged. Primary source: RFC 9112 §4, https://www.rfc-editor.org/rfc/rfc9112.html#section-4
|
/oc Repair the exact-head CI failures on
Run repository Python contracts, |
|
@opencode-agent address Exact-current-head repair request for Current production defect: Use strict RED→GREEN TDD. First add realistic authenticated-loopback regressions that (1) accept a valid |
Buyer-visible problem
OriginWeave still needs one bounded HTTP/1.1 exchange over an already authenticated
AuthenticatedTlsConnection. This branch contains the extensive implementation and fail-first history for issue #9, but it is no longer integration-ready against current protected main.Intended product boundary
GETorHEADexchange over the existing governed TLS stream;The design and implementation history remain in:
docs/superpowers/specs/2026-08-07-http11-semantics-design.mddocs/superpowers/plans/2026-08-07-http11-semantics.mdCurrent integration state
Current contributor head:
293ab063e13b1bf23f622935c3e01886cf06dbff.Current protected main:
076da4296a13d11c70cce8f99163ebcd10ad2daf.This PR is Draft and not mergeable because it is based on historical main and has diverged substantially while destination/proxy, sensitive-data, resource, TLS-horizon, extension-authority, review-governance, and hourly-automation work integrated on protected main. Historical exact-head successes on predecessor heads remain useful regression evidence but do not qualify the current branch or current live base.
The next integration action is a non-destructive reconstruction/reconciliation onto the exact current protected main, preserving all unique HTTP implementation/tests/doctoring while adopting current workspace, coverage, governance, and adjacent authority contracts. No predecessor check, approval, mergeability result, or synthetic merge evidence transfers after that head changes.
Governance
Merge eligibility follows current protected-main
docs/quality-gates.md: exact-head CI/security/coverage/rustdoc, resolved current findings, live-base/writer-lease checks, branch protection, and any operationally required review authority. No self/synthesized approval or technical-gate weakening is permitted.Closes #9 only after the reconciled exact head satisfies the complete issue acceptance boundary.