feat(http): rebuild bounded HTTP/1.1 authority on current main - #37
Open
seonghobae wants to merge 63 commits into
Open
feat(http): rebuild bounded HTTP/1.1 authority on current main#37seonghobae wants to merge 63 commits into
seonghobae wants to merge 63 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesBounded HTTP/1.1 교환
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the title
seonghobae
marked this pull request as ready for review
August 9, 2026 18:14
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adr/0011-bounded-http11-semantics.md`:
- Line 128: Update the RFC 9651 reference in the ADR bibliography to list M.
Nottingham and P-H. Kamp as the authors, replacing L. Pardue while preserving
the existing APA 7 formatting and citation details.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 309012b3-0507-4ad0-a120-79860db60d68
📒 Files selected for processing (8)
crates/originweave-http/src/exchange.rscrates/originweave-http/src/integrity.rscrates/originweave-http/src/response_head.rscrates/originweave-http/tests/response_failure_regressions.rsdocs/adr/0011-bounded-http11-semantics.mddocs/doctoring/http11-security-evidence.mddocs/superpowers/plans/2026-08-07-http11-semantics.mddocs/superpowers/specs/2026-08-07-http11-semantics-design.md
🚧 Files skipped from review as they are similar to previous changes (5)
- docs/doctoring/http11-security-evidence.md
- crates/originweave-http/src/response_head.rs
- docs/superpowers/plans/2026-08-07-http11-semantics.md
- crates/originweave-http/src/exchange.rs
- crates/originweave-http/src/integrity.rs
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 95: Update the workflow step containing the `cargo llvm-cov report | tee
missing-lines.txt` pipeline to enable pipefail before running it, ensuring
failures from `cargo llvm-cov report` propagate instead of being masked by
`tee`.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: db50be84-103e-4454-aec3-105b7dd2e9e6
📒 Files selected for processing (5)
.github/workflows/ci.ymlcrates/originweave-http/src/integrity.rscrates/originweave-http/src/lib.rscrates/originweave-http/src/tests/no_content_integrity_contract.rscrates/originweave-http/src/tests/response_debug_runtime_contract.rs
🚧 Files skipped from review as they are similar to previous changes (3)
- crates/originweave-http/src/tests/no_content_integrity_contract.rs
- crates/originweave-http/src/lib.rs
- crates/originweave-http/src/integrity.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Complete the non-destructive reconstruction of issue #9 / historical PR #11 on current protected-main lineage. The replacement restores the bounded
originweave-httpproduction crate, realistic integration tests, governing ADR/doctoring, and current workspace/governance contracts without replaying obsolete branch-specific coverage machinery or overwriting protected-main network/TLS/proxy/sensitive-data/resource/extension/governance work.Reconstruction evidence
The current replacement preserves the predecessor's production HTTP semantics while adopting current-main contracts rather than its stale branch history. Exact blob comparisons on representative high-risk production modules are identical between historical #11 head
293ab063e13b1bf23f622935c3e01886cf06dbffand this replacement: chunked transfer/trailers, content decoding, exchange orchestration, message framing, RFC 9530 integrity, request serialization, and response-head parsing. The only observedfield.rsdifference is explanatory commentary around ASCII lowercase normalization, not executable behavior. Historical modifications to the old custom coverage verifier are deliberately not replayed because protected main now owns the canonical exact coverage pipeline; this replacement passes that current pipeline.The replacement also repaired one reconstruction defect in
Cargo.lock: thecpufeatures 0.2.17checksum had diverged from protected main/crates.io, causingcargo check --lockedand coverage dependency resolution to fail. The exact lock checksum was restored, not bypassed.Product boundary
GETorHEADexchange over an existing authenticatedAuthenticatedTlsConnection;Exact-head evidence
Exact head
d7f05b2b9b1562b24e6704007d6fae17df8d58f4is currently mergeable against protected main. On that unchanged head:31328226623: success;31328226635: success;31328226633: success;Current protected main advanced after the branch was created only through the canonical documentation reconciliation and the disjoint MV3 restart-persistence test slice. Live compare shows no overlapping changed files with this HTTP replacement, and GitHub reports the PR mergeable. Current solo-maintainer review governance therefore leaves technical/security gates mandatory without synthesizing approval.
Supersession
After protected merge and protected-main verification, historical PR #11 can be closed as superseded by this clean current-lineage reconstruction. Historical predecessor checks/reviews are not reused as merge authority.
Closes #9.
Summary by CodeRabbit