Repository navigation
Extract shared arg-cursor for orchestrator parsers (#127) - #148
Merged
Merged
Conversation
added 2 commits
October 13, 2026 02:16
Dedupes the --flag=value/next() cursor duplicated across cli.ts and resume.ts into src/orchestrator/arg-cursor.ts with unit tests; regen architecture baseline for moved clone keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127 (partial — first slice: arg-cursor extraction).
What
Extracts the duplicated
--flag=value/next()argv-cursor idiom (7 copies acrosssrc/orchestrator/cli.ts:354andsrc/orchestrator/resume.ts:124) intosrc/orchestrator/arg-cursor.ts:45(createArgCursor), with unit tests atsrc/orchestrator/__tests__/arg-cursor.test.ts. Callers inparseOrchestrateArgs,parseStatusArgs,parseStopArgs,parsePipelineArgs,parseReviewArgs,parseReworkArgs,parseResumeArgsnow delegate. Also removes strayPLAN.mdand regeneratesscripts/architecture-baseline.jsonfor moved clone keys.Gates (honest status)
npx tsc --noEmit: GREEN (exit 0)npm run check-standards: GREEN (all baselined, 0 fixed)npm run check-architecture: GREEN after baseline regen (38 moved clone keys re-baselined in same change; 0 fixed since baseline after regen)npm test(full): NOT GREEN — 1 pre-existing failure insrc/orchestrator/__tests__/cleanup.test.ts:355(testApplySyncsMainToOrigin: remote main SHA != local main SHA after cleanup --apply push). Reproduces on the clean tree with this diff stashed, so unrelated to this slice. Docker-provider flake seen once, passes on retry.npm run coverage -- --min 24: BLOCKED by the same cleanup failure (coverage script exits nonzero when the suite fails before reaching the floor check).npx tsx src/orchestrator/__tests__/arg-cursor.test.ts— 6/6 pass.Shippable partial per brief: slice is committed, no new refactors started.