ci: enforce regression tests and harden import loading - #329
ci: enforce regression tests and harden import loading#329somethingwithproof wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR repairs the plugin’s GitHub Actions integration workflow to make it deterministic and fix several workflow/runtime issues encountered across plugins, without changing any plugin PHP code.
Changes:
- Pin the Cacti core checkout to
release/1.2.31to avoid testing against a moving default branch. - Fix
find -exec php -lredirection placement so actionlint/shellcheck no longer flags SC2227. - Fix MySQL authentication by constructing
--defaults-fileusing$HOMEinside therun:block (avoids literal~), and remove the PHP-version-suffixed Apache module install in favor oflibapache2-mod-php.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
# Conflicts: # .github/workflows/plugin-ci-workflow.yml
|
Final maintenance audit is complete: this PR is a single-purpose, one-commit change, is based on current |
c64f592 to
22eebf4
Compare
22eebf4 to
1cf580f
Compare
|
@TheWitness #329 is now a single rebased commit with all GitHub checks green. It makes the regression scripts blocking, fixes the integration matrix, and includes the PHP 8 zero-byte import guard found by the review gate. The branch-protection rule requires approval from someone other than the last pusher; please review/approve and squash-merge when ready. #320 and #326 are intentionally waiting to rebase onto this rather than duplicating its workflow commit. |
Summary
fread(..., 0)ValueErrorfailures.PHP compatibility
The import reader uses PHP 8.0-compatible union types and
try/finally; it does not introduce PHP 8.1-only syntax.Validation
functions.phppasses PHP lint.actionlintpasses.This supersedes #327. PRs #326 and #320 should be rebased onto
developafter this lands so they inherit the corrected CI gate without duplicating workflow commits.