Skip to content

ci: enforce regression tests and harden import loading - #329

Open
somethingwithproof wants to merge 1 commit into
Cacti:developfrom
somethingwithproof:ci/fix-integration-workflow
Open

ci: enforce regression tests and harden import loading#329
somethingwithproof wants to merge 1 commit into
Cacti:developfrom
somethingwithproof:ci/fix-integration-workflow

Conversation

@somethingwithproof

@somethingwithproof somethingwithproof commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Repair the integration workflow package installation, MySQL authentication, lint redirection, and pinned Cacti checkout.
  • Make every standalone PHP regression script a required CI step.
  • Realign stale regression assertions with the current sequence-bounded alert query and centralized import helper.
  • Reject empty or unreadable XML import files without triggering PHP 8 fread(..., 0) ValueError failures.

PHP compatibility

The import reader uses PHP 8.0-compatible union types and try/finally; it does not introduce PHP 8.1-only syntax.

Validation

  • All eight regression scripts pass.
  • functions.php passes PHP lint.
  • actionlint passes.
  • The repository pre-push review gate passed with no critical, high, or medium findings.

This supersedes #327. PRs #326 and #320 should be rebased onto develop after this lands so they inherit the corrected CI gate without duplicating workflow commits.

Copilot AI lite review requested due to automatic review settings August 17, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR repairs the plugin’s GitHub Actions integration workflow to make it deterministic and fix several workflow/runtime issues encountered across plugins, without changing any plugin PHP code.

Changes:

  • Pin the Cacti core checkout to release/1.2.31 to avoid testing against a moving default branch.
  • Fix find -exec php -l redirection placement so actionlint/shellcheck no longer flags SC2227.
  • Fix MySQL authentication by constructing --defaults-file using $HOME inside the run: block (avoids literal ~), and remove the PHP-version-suffixed Apache module install in favor of libapache2-mod-php.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

somethingwithproof added a commit that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
somethingwithproof added a commit to somethingwithproof/plugin_syslog that referenced this pull request Aug 17, 2026
# Conflicts:
#	.github/workflows/plugin-ci-workflow.yml
@somethingwithproof

Copy link
Copy Markdown
Member Author

Final maintenance audit is complete: this PR is a single-purpose, one-commit change, is based on current develop, has no unresolved review threads, and all checks are green. GitHub still requires approval from someone other than the last pusher. @TheWitness, please review/approve and merge this first; #327 is superseded by this PR and the remaining Syslog branches will be rebased after it lands.

@somethingwithproof
somethingwithproof force-pushed the ci/fix-integration-workflow branch from 22eebf4 to 1cf580f Compare August 28, 2026 04:58
@somethingwithproof somethingwithproof changed the title ci: repair the integration workflow ci: enforce regression tests and harden import loading Aug 28, 2026
@somethingwithproof

Copy link
Copy Markdown
Member Author

@TheWitness #329 is now a single rebased commit with all GitHub checks green. It makes the regression scripts blocking, fixes the integration matrix, and includes the PHP 8 zero-byte import guard found by the review gate. The branch-protection rule requires approval from someone other than the last pusher; please review/approve and squash-merge when ready. #320 and #326 are intentionally waiting to rebase onto this rather than duplicating its workflow commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants