Skip to content

compat: make PHP 8 HTML escaping behavior explicit - #333

Open
somethingwithproof wants to merge 1 commit into
Cacti:developfrom
somethingwithproof:fix/php8-deprecations
Open

compat: make PHP 8 HTML escaping behavior explicit#333
somethingwithproof wants to merge 1 commit into
Cacti:developfrom
somethingwithproof:fix/php8-deprecations

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Summary

  • Pass explicit ENT_QUOTES | ENT_SUBSTITUTE flags and UTF-8 to the remaining htmlspecialchars() call.
  • Preserve PHP 8.1+ behavior while removing the cross-version compatibility finding.
  • Record the compatibility cleanup in the develop changelog.

Audit result

A whole-plugin PHPCompatibility scan for PHP 8.0+ found five findings on develop. This PR resolves the htmlspecialchars() finding. The other four are omitted fputcsv() escape arguments and are already resolved in #326.

Validation

  • setup.php passes PHP lint.
  • setup.php is clean under PHPCompatibility with testVersion 8.0-.
  • The full pre-push review gate passed.

CI infrastructure repair #329 should merge first so this PR inherits the corrected PHP matrix after rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant