Skip to content

refactor: enhance semantic HTML by adding ARIA roles to header, footer, and main elements #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cedric07 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor: enhance semantic HTML by adding ARIA roles to header, footer, and main elements #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25ef94
refactor: enhance semantic HTML by adding ARIA roles to header, foote…
cedric07 Apr 27, 2026
f4e1d80
fix bugbot: correct indentation in footer.php
cedric07 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion footer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
</main>
<footer id="footer" tabindex="-1" class="footer" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">
<footer role="contentinfo" id="footer" tabindex="-1" class="footer" aria-label="<?php esc_attr_e( 'Footer', 'beapi-frontend-framework' ); ?>">

</footer>
<?php wp_footer(); ?>
Expand Down
6 changes: 3 additions & 3 deletions header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
</li>
</ul>
</nav>
<header id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<header role="banner" id="header" class="header" aria-label="<?php esc_attr_e( 'Header', 'beapi-frontend-framework' ); ?>">
<div class="header__inner">
<div class="container">
<a class="header__logo-link" href="<?php echo esc_url( home_url( '/' ) ); ?>">
Expand All @@ -55,7 +55,7 @@
<span class="sr-only aria-expanded-true-text"><?php esc_html_e( 'Close the menu', 'beapi-frontend-framework' ); ?></span>
</button>

<nav id="menu" tabindex="-1" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>">
<nav role="navigation" id="menu" tabindex="-1" class="header__menu" aria-label="<?php esc_attr_e( 'Main navigation', 'beapi-frontend-framework' ); ?>">
<div>
<?php
wp_nav_menu(
Expand All @@ -74,7 +74,7 @@
</div>
</div>
</header>
<main id="content" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
<main role="main" id="content" tabindex="-1" aria-label="<?php esc_attr_e( 'Main content', 'beapi-frontend-framework' ); ?>">
<?php
if ( ! is_front_page() && ! is_search() && ! is_404() ) {
get_template_part( 'components/parts/common/breadcrumb' );
Expand Down
Loading