Skip to content

refactor: enhance semantic HTML by adding ARIA roles to header, footer, and main elements#490

Open
cedric07 wants to merge 2 commits intomasterfrom
fix/landmarks
Open

refactor: enhance semantic HTML by adding ARIA roles to header, footer, and main elements#490
cedric07 wants to merge 2 commits intomasterfrom
fix/landmarks

Conversation

@cedric07
Copy link
Copy Markdown
Contributor

@cedric07 cedric07 commented Apr 27, 2026

Le RGAA recommande de conserver ces attributs même s'ils disposent de lien d'accès rapides : https://accessibilite.numerique.gouv.fr/methode/glossaire/#landmarks et https://accessibilite.numerique.gouv.fr/methode/criteres-et-tests/#12.6

C'était également un retour de Temesis lors d'un audit.


Note

Low Risk
Pure markup/accessibility changes (adds roles) with no impact on business logic or data handling; minimal risk aside from potential CSS/JS selectors that might rely on attributes.

Overview
Improves accessibility semantics by explicitly adding ARIA landmark role attributes to the theme layout.

header.php now sets role="banner" on the header, role="navigation" on the main menu nav, and role="main" on the main content container; footer.php adds role="contentinfo" to the footer.

Reviewed by Cursor Bugbot for commit f4e1d80. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d25ef94. Configure here.

Comment thread footer.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant