Repository navigation
Refactor adapter GET, and add adapter POST method for push - #137
Draft
Tom-Kingstone wants to merge 3 commits into
Draft
Tom-Kingstone wants to merge 3 commits into
Tom-Kingstone wants to merge 3 commits into
Conversation
… to use the adapter and GET methods in the same way as before)
Tom-Kingstone
force-pushed
the
HTTP_Toolkit-#134-AddPOSTAndRefactorGET
branch
from
October 15, 2026 12:57
7dc1a29 to
bdd9d0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #134
Closes #72
Simple attempt to make this adapter more usable from ASP.NET and Aspire applications (i.e. use this adapter as an API client).
As this is only for GET and POST requests directed through the adapter this shouldn't affect other toolkits
This also fixes #72
changers to adapter constructors:
Adapter property: HttpClient, allows an application to directly send requests with an already configured client if the existing adapter functionality isn't enough.
Changes to GET:
application/bhom, which will just return the response content as a string instead (so a different json serialiser can be used if necessary).New POST:
application/bhomor the config specifies to try force convert to BHoM objects, otherwise it returns the response string.Test files
TODO: probably will make a simple API to test this locally.
Changelog
Additional comments