Repository navigation
User authentication - #9
Open
Tom-Kingstone wants to merge 5 commits into
Open
Tom-Kingstone wants to merge 5 commits into
Tom-Kingstone wants to merge 5 commits into
Conversation
…, also allowing using a mock api adapter for testing.
Tom-Kingstone
changed the title
JohannaOlin1
approved these changes
Oct 19, 2026
JohannaOlin1
left a comment
JohannaOlin1
left a comment
There was a problem hiding this comment.
Have tested pulling materials and design/project results (using the design and tool ids in the unit tests) and they have been populated correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/HTTP_Toolkit#137
Issues addressed by this PR
Closes #8
Added very simple (probably not at all secure) user auth to allow ensuring that the correct subset of users are using the tool.
Also updated the adapter with extra constructors to allow for more useful unit and functionality tests, and allows it to be used in ZCTs with dependency injection.
Test files
See the unit tests that check basic functionality without needing to actually get projects/data from the OneClick LCA API.
Make sure to check that the user API works properly (test pulling projects, then designs/results from a project and see if the objects are populated properly).
Changelog
Additional comments