Skip to content

fix(libs): set maxSupportedTransactionVersion on Wormhole getTransaction #14598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickyrombo wants to merge 1 commit into from
Closed

fix(libs): set maxSupportedTransactionVersion on Wormhole getTransaction #14598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/libs/src/services/wormhole/Wormhole.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import type { GetSignedVAAResponse } from '@certusone/wormhole-sdk/lib/cjs/proto
import type {
RpcResponseAndContext,
SignatureResult,
Transaction
Transaction,
TransactionResponse
} from '@solana/web3.js'
import bs58 from 'bs58'
import { BN, toBuffer } from 'ethereumjs-util'
Expand Down Expand Up @@ -362,7 +363,13 @@ export class Wormhole {
phase = phases.GET_EMITTER_ADDR

// Get the sequence number and emitter address required to fetch the signedVAA of our message
const info = await connection.getTransaction(transactionSignature)
// Declare the highest transaction version this client can decode. RPC
// providers reject getTransaction requests that omit this now that
// Transaction v1 is live. web3.js 1.x decodes legacy and v0 only, and the
// transaction relayed above is always legacy, so 0 is correct here.
const info = (await connection.getTransaction(transactionSignature, {
maxSupportedTransactionVersion: 0
})) as TransactionResponse | null
const sequence = this.wormholeSDK.parseSequenceFromLogSolana(info!)
const emitterAddress = await this.wormholeSDK.getEmitterAddressSolana(
this.solTokenBridgeAddress
Expand Down
Loading