fix(libs): set maxSupportedTransactionVersion on Wormhole getTransaction - #14598
Closed
rickyrombo wants to merge 1 commit into
Closed
rickyrombo wants to merge 1 commit into
rickyrombo wants to merge 1 commit into
Conversation
Transaction v1 activates on Solana mainnet on 2026-09-15. RPC providers now require getTransaction callers to declare the highest transaction version they can decode. web3.js 1.x decodes legacy and v0 only, and the transaction fetched here is the legacy transaction relayed just before, so 0 is the correct value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Contributor
Author
|
dead code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Helius flagged
getTransactioncalls that do not setmaxSupportedTransactionVersionahead of Transaction v1 activating on mainnet (2026-09-15). This is the only unconfiguredgetTransactioncall in this repo; the live Solana indexer lives in theapirepo (see AudiusProject/api#1040).What
Wormhole.tsin the legacy SDK now passes{ maxSupportedTransactionVersion: 0 }. web3.js 1.98 can only decode legacy and v0 messages, and this call only re-reads the legacy transaction relayed a few lines earlier, so it can never hit a v1 transaction. The value makes the client's capability explicit rather than relying on the RPC default.Sending
1here would require migrating the legacy SDK to web3.js v3 or Kit, which is out of scope. I found no caller of this Wormhole flow in web or mobile.Verification
tsc --noEmitand eslint pass forpackages/libs.🤖 Generated with Claude Code