Use POST for Discord JWT request#14521
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /request_discord_codewith a JSON body instead of query paramsstatepayload before appending it to the OAuth URLContext
PR #14520 fixed the mixed-content issue by switching the production Discord bot URL to HTTPS. This follow-up moves signature/message transport out of the URL and into a JSON request body, avoiding URL length and query logging concerns.
Companion PRs
Rollout
Merge/deploy after the bot supports POST. Recommended order:
discord-bot-JWT_SECRETin GCP Secret Manager.Test plan
git diff --checkCould not run local Vitest because this worktree has no installed
node_modules, sovitestis unavailable (sh: vitest: command not found).