Skip to content

Fix Launch VIP Discord mixed content#14520

Merged
raymondjacobson merged 1 commit into
mainfrom
codex/fix-launch-vip-discord
Jul 13, 2026
Merged

Fix Launch VIP Discord mixed content#14520
raymondjacobson merged 1 commit into
mainfrom
codex/fix-launch-vip-discord

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Jul 13, 2026

Copy link
Copy Markdown
Member

Summary

  • switch the production Discord bot server from HTTP to HTTPS
  • add a regression test covering the production Discord endpoint

Diagnosis

The Launch VIP Discord flow was blocked by the browser because https://audius.co/rewards tried to fetch http://discord.audius.co/request_discord_code. The HTTP endpoint redirects to HTTPS, but browsers block mixed-content requests before following that redirect.

Follow-ups

Test plan

  • git diff --check -- packages/web/src/services/env/env.prod.ts packages/web/src/services/env/env.prod.test.ts
  • curl -sSIL --max-time 10 https://discord.audius.co/request_discord_code returns an app-level response over HTTPS, confirming the HTTPS endpoint is reachable

Could not run the focused Vitest test locally because this worktree had no installed node_modules, so vitest was unavailable (sh: vitest: command not found).

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: acf153d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson merged commit 5e4ac06 into main Jul 13, 2026
9 checks passed
@raymondjacobson raymondjacobson deleted the codex/fix-launch-vip-discord branch July 13, 2026 22:24
@raymondjacobson raymondjacobson changed the title Fix Launch VIP Discord mixed content Fix Launch VIP Discord JWT request Jul 13, 2026
@raymondjacobson raymondjacobson changed the title Fix Launch VIP Discord JWT request Fix Launch VIP Discord mixed content Jul 13, 2026
raymondjacobson added a commit that referenced this pull request Jul 13, 2026
## Summary
- send the Discord JWT request as `POST /request_discord_code` with a
JSON body instead of query params
- encode the Discord OAuth `state` payload before appending it to the
OAuth URL

## Context
PR #14520 fixed the mixed-content issue by switching the production
Discord bot URL to HTTPS. This follow-up moves signature/message
transport out of the URL and into a JSON request body, avoiding URL
length and query logging concerns.

## Companion PRs
- Bot POST support:
AudiusProject/discord-audio-bot#24
- k8s JWT secret wiring:
AudiusProject/audius-k8s#514

## Rollout
Merge/deploy after the bot supports POST. Recommended order:
1. Create/set `discord-bot-JWT_SECRET` in GCP Secret Manager.
2. Merge/apply the k8s secret wiring PR.
3. Merge/deploy the bot POST-support PR.
4. Merge/deploy this apps PR.

## Test plan
- `git diff --check`

Could not run local Vitest because this worktree has no installed
`node_modules`, so `vitest` is unavailable (`sh: vitest: command not
found`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant