Skip to content

Restore drag position against children, not childNodes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kebechet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Restore drag position against children, not childNodes #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions BlazorSortableList.Lib/SortableList.razor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export function init(id, group, pull, put, sort, handle, filter, component, forc

let oldIndicies = Array.from(event.oldIndicies);
oldIndicies.forEach((item) => {
event.to.insertBefore(item.multiDragElement, event.to.childNodes[item.index]);
event.to.insertBefore(item.multiDragElement, event.to.children[item.index]);
});
} else {
if (DEBUG_MODE) {
Expand All @@ -105,7 +105,7 @@ export function init(id, group, pull, put, sort, handle, filter, component, forc

// method inserts a child node before an existing child. insertBefore(newNode, referenceNode)
// referenceNode - The node before which newNode is inserted
event.to.insertBefore(event.item, event.to.childNodes[event.oldIndex]);
event.to.insertBefore(event.item, event.to.children[event.oldIndex]);
}
// Notify .NET to update its model and re-render
component.invokeMethodAsync('OnUpdateJS', oldIndex, newIndex, event.from.id);
Expand Down Expand Up @@ -138,12 +138,12 @@ export function init(id, group, pull, put, sort, handle, filter, component, forc

let oldIndicies = Array.from(event.oldIndicies);
oldIndicies.forEach((item) => {
event.from.insertBefore(item.multiDragElement, event.from.childNodes[item.index]);
event.from.insertBefore(item.multiDragElement, event.from.children[item.index]);
});
} else {
// Revert the DOM to match the .NET state
event.item.remove();
event.from.insertBefore(event.item, event.from.childNodes[event.oldIndex]);
event.from.insertBefore(event.item, event.from.children[event.oldIndex]);
}

// Notify .NET to update its model and re-render
Expand Down