Restore drag position against children, not childNodes

[Kebechet]

Problem

The DOM-revert logic in onUpdate/onRemove resolves the reference node through childNodes:

event.to.insertBefore(event.item, event.to.childNodes[event.oldIndex]);

childNodes is a NodeList that includes text and comment nodes, while the indices SortableJS reports count elements only. Any whitespace text node or comment between items — both of which a Blazor render tree can emit around the item template — shifts the reference node and the item is reinserted at the wrong position, leaving the DOM out of step with the .NET model.

onSelect/onDeselect in the same file already use .children for exactly this reason, so the two index spaces were mixed within one module.

Implementation

Replaced all four childNodes lookups with children (an HTMLCollection of elements only). Where no non-element nodes exist the two are equivalent, so this is a no-op in the working case and a fix in the rest.

Index semantics are otherwise untouched — the existing oldIndex vs oldDraggableIndex split is left as-is.

[coderabbitai]

Warning

Review limit reached

@Kebechet, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eeac2a45-be97-453b-894c-afa5380245fb

📥 Commits

Reviewing files that changed from the base of the PR and between 6b2c5ba and bdcb95c.

📒 Files selected for processing (1)

• BlazorSortableList.Lib/SortableList.razor.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR fixes DOM revert logic in the SortableJS interop so that drag revert operations use element-only indexing (matching SortableJS indices) rather than childNodes, which can be shifted by Blazor-emitted whitespace/comment nodes.

Changes:

• Replaced event.to.childNodes[...] with event.to.children[...] when reinserting items during onUpdate revert.
• Replaced event.from.childNodes[...] with event.from.children[...] when reinserting items during onRemove revert.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.