Skip to content

render: guard generateImpostor against degenerate fov/aspect #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Quinn-Elara wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

render: guard generateImpostor against degenerate fov/aspect #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions indra/newview/pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12546,13 +12546,32 @@ void LLPipeline::generateImpostor(LLVOAvatar* avatar, bool preview_avatar, bool
tdim.mV[0] = half_height.dot3(left).getF32();
tdim.mV[1] = half_height.dot3(up).getF32();

gGL.matrixMode(LLRender::MM_PROJECTION);
gGL.pushMatrix();

F32 distance = (pos-camera.getOrigin()).length();
F32 fov = atanf(tdim.mV[1]/distance)*2.f*RAD_TO_DEG;
F32 aspect = tdim.mV[0]/tdim.mV[1];

// Guard against degenerate geometry: the avatar's bounding box can project
// to zero in one or both axes (collapsed extents, extreme distance, or a
// lookAt singularity when the avatar is directly above/below the camera).
// fov==0 or non-finite aspect both produce an unusable projection matrix
// and assert-crash inside glm::perspectiveRH_NO.
if (fov <= 0.f || !std::isfinite(aspect) || aspect <= 0.f)
{
LL_WARNS_ONCE("AvatarRenderPipeline") << "generateImpostor: degenerate fov/aspect for avatar "
<< avatar->getID() << " (fov=" << fov << " aspect=" << aspect
<< " distance=" << distance << " tdim=" << tdim.mV[0] << "," << tdim.mV[1]
<< ") -- skipping impostor bake this frame" << LL_ENDL;
popRenderTypeMask();
sUseOcclusion = occlusion;
sShadowRender = saved_shadow_render;
sImpostorRender = saved_impostor_render;
return;
}

gGL.matrixMode(LLRender::MM_PROJECTION);
gGL.pushMatrix();

// Clip planes bracketing the subject instead of a hardcoded 1..256.
//
// Impostoring is chosen by rank, not distance (LLVOAvatar::shouldImpostor), so an
Expand Down