render: guard generateImpostor against degenerate fov/aspect - #392
Open
Quinn-Elara wants to merge 1 commit into
Open
Quinn-Elara wants to merge 1 commit into
Quinn-Elara wants to merge 1 commit into
Conversation
When an avatar's spatial extents project to zero in the camera's up axis (collapsed bounding box, extreme distance, or a lookAt singularity when the avatar is directly above or below the camera), tdim.mV[1] is zero. This produces fov=0 and aspect=NaN, which assert-crash inside glm::perspectiveRH_NO before the perspective matrix is written. Add a finite/positive check on fov and aspect before the GL matrix push. On failure, restore pushRenderTypeMask, sUseOcclusion, sShadowRender and sImpostorRender and return early. Move the MM_PROJECTION pushMatrix to after the guard so no pop is needed on the early-out path and the normal path has exactly one push. Fixes a reproducible crash when impostoring a distant avatar (>3km) while the viewer window is in the background.
Contributor
|
Warning Review limit reachedNext included review available in 40 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an avatar's spatial extents project to zero in the camera's up axis (collapsed bounding box, extreme distance, or a lookAt singularity when the avatar is directly above or below the camera), tdim.mV[1] is zero. This produces fov=0 and aspect=NaN, which assert-crash inside glm::perspectiveRH_NO before the perspective matrix is written.
Add a finite/positive check on fov and aspect before the GL matrix push. On failure, restore pushRenderTypeMask, sUseOcclusion, sShadowRender and sImpostorRender and return early. Move the MM_PROJECTION pushMatrix to after the guard so no pop is needed on the early-out path and the normal path has exactly one push.
Fixes a reproducible crash when impostoring a distant avatar (>3km) while the viewer window is in the background.
Related Issues
Issue Link:
Checklist
Please ensure the following before requesting review:
Additional Notes