Repository navigation
QLoRA Support + NNX Decoder Sharding Fixes - #3968
Merged
Merged
Conversation
RexBearIU
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
May 22, 2026 07:27
4 tasks done
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
2 times, most recently
from
June 1, 2026 06:59
c37faef to
4dde975
Compare
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
from
June 8, 2026 07:20
4dde975 to
6a12059
Compare
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
5 times, most recently
from
June 23, 2026 01:15
4d44567 to
67eec07
Compare
shralex
approved these changes
Jun 24, 2026
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
4 times, most recently
from
June 24, 2026 08:12
2a0276d to
bdc5177
Compare
khatwanimohit
approved these changes
Jun 24, 2026
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
2 times, most recently
from
June 25, 2026 10:04
82a010b to
1eae130
Compare
RexBearIU
force-pushed
the
jackyf/qlora-support
branch
from
June 25, 2026 10:09
1eae130 to
ef34fac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces core support for QLoRA and implements robust sharding metadata synchronization for NNX decoders.
Currently, applying LoRA adapters alongside quantization and complex multi-host sharding setups can lead to PartitionSpec mismatches and cross-backend device_put issues during lax.scan.
This PR solves these issues by:
Future improvements will include removing the _safe_reshard workaround once the underlying JAX/Qwix parameter materialization issues are fully resolved upstream.
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.