Repository navigation
Conversation
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
3 times, most recently
from
April 21, 2026 08:48
669b501 to
9634d50
Compare
RexBearIU
force-pushed
the
jackyf/qlora
branch
2 times, most recently
from
April 22, 2026 08:01
a2739ab to
fc27813
Compare
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
22 times, most recently
from
April 29, 2026 12:28
8531d67 to
de940c3
Compare
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
4 times, most recently
from
May 4, 2026 07:13
ca8af65 to
5a7bedb
Compare
RexBearIU
force-pushed
the
jackyf/qlora
branch
11 times, most recently
from
May 4, 2026 11:06
2d237f8 to
f8a7f1b
Compare
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
from
May 5, 2026 08:03
5a7bedb to
397f319
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
5 times, most recently
from
May 8, 2026 11:11
391664f to
1eb5953
Compare
shralex
force-pushed
the
jackyf/feat/lora-nnx
branch
2 times, most recently
from
May 8, 2026 15:01
3954ce8 to
6face5b
Compare
RexBearIU
force-pushed
the
jackyf/feat/lora-nnx
branch
from
May 11, 2026 10:20
6face5b to
eced9d7
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive, out-of-the-box support for QLoRA (Quantized Low-Rank Adaptation) and fixes critical initialization crashes that occurred when running LoRA/QLoRA Fine-Tuning in multi-host TPU environments. It
unifies the array distribution logic so that both Dense models (like Llama 3) and Mixture-of-Experts models (like Gemma 4) work seamlessly on both Pathways and standard McJAX backends.
What was added/changed:
lora_llama3_demo.ipynb notebook.
gracefully constructs the global array by extracting its required physical slice directly from its local CPU copy.
Tests
Validated initialization, compilation, and training on a 2-slice v6e-8 cluster:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.