Drop support for Python 3.9, move metadata to pyproject.toml#310
Open
Drop support for Python 3.9, move metadata to pyproject.toml#310
Conversation
Contributor
perrinjerome
left a comment
perrinjerome
left a comment
There was a problem hiding this comment.
I do not have very good knowledge of the details of python 3.9 (I mean it would be good if somebody else could also review), but this looks good to me.
|
|
||
| else: # pragma: no cover | ||
| # Index, Slice and ExtSlice are only defined Slice types. | ||
| # Slice is the only defined Slice type. |
Contributor
There was a problem hiding this comment.
If I followed correctly, all this code became not used in 3.9 and new PEG parser. In 3.9 the names still existed but were already not used.
It seems fine to remove this code now it was probably even possible to remove when dropping python 3.8.
I just want to suggest updating the docstring, because this does not transform anything now.
Member
Author
There was a problem hiding this comment.
I actually ended up removing the transformation altogether, it was obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following: