fix: make QdrantLocal runnable from the web UI - #867
Open
serhiizghama wants to merge 3 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serhiizghama The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #796. QdrantLocal can't be run from the web UI at all —
QdrantLocalIndexConfigrequiresmandef_construct, but there's noDB.QdrantLocalentry inCASE_CONFIG_MAP, so the UI renders "Auto", passes an empty config, and pydantic raises2 validation errors ... Field requiredbefore the run starts. That matches the reporter's "seems like 'ef_construct' is missing, but there is not such option" — the option genuinely isn't there.Gave both fields the same defaults the CLI already uses (
m=16,ef_construct=200) and registered QdrantLocal inCASE_CONFIG_MAPsom,ef_constructandon_diskare tunable for load, plushnsw_effor search — the same four knobsqdrant_local/cli.pyexposes. Needed two newCaseConfigParamTypemembers since the existingef_constructionspelling doesn't match the model field.The CLI path is unchanged: it always passed these explicitly. Verified the empty-config case now builds, that the UI defaults round-trip into
index_param()/search_param(), and that tuned values reach the client. New tests fail on main and pass here.