Fix: results sharing a task_label are dropped (show all, not just the first) - #864
Open
muralikpbhat wants to merge 1 commit into
Open
Fix: results sharing a task_label are dropped (show all, not just the first)#864muralikpbhat wants to merge 1 commit into
muralikpbhat wants to merge 1 commit into
Conversation
getshownResults mapped each selected label back with resultSelectOptions.index( option), which returns only the first TestResult carrying that label. When two or more TestResults share a task_label (e.g. the same engine re-run under one label), every result after the first was silently dropped from all results pages. Iterate all (option, result) pairs and include each whose label is selected. No change when labels are unique.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: muralikpbhat The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getshownResults(frontend/components/check_results/filters.py) maps each selected task-label back to its results withresultSelectOptions.index(option), which returns only the first TestResult carrying that label. When two or more TestResults share atask_label, every result after the first is silently dropped from all results pages (Results, Qps & Recall, Queries-Per-Dollar, Tables, …).Repro
--task-label demo→results/<DB>/result_<date>_demo_<db>.json.--task-label demo→ a second result file / TestResult.demo: only the first run is plotted; the second run's DB/points never appear, even though both files exist and load.Fix
Iterate every
(option, result)pair and include each result whose label is selected, instead ofindex()-ing only the first match. No behavior change when task labels are unique.