fix: cancel stale completion requests - #3263
Open
atirna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I cancel outstanding completion requests when a document-changing notification arrives. Completion declaration loops now check for cancellation, so stale requests release before the document refreshes.
Fixes #3251
Why
Large generated C bindings can make completion enumeration expensive. The response should reflect the latest document instead of waiting for earlier edits to finish.
Verification
master: a 30,000-declaration import with eight rapidtextDocument/didChangeand completion pairs left the newest response pending for 19.523 secondszig build test -Dtest-filter=completionzig build test