Skip to content

Protect base venv cache save against cancellation #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheJulianJES wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Protect base venv cache save against cancellation #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df34eaf
Prevent reserved-but-empty base venv cache via `fail-fast: false`
TheJulianJES May 31, 2026
3caa310
Protect base venv cache save against cancellation
TheJulianJES May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ jobs:
with:
enable-cache: false
- name: Create Python virtual environment
id: create-venv
if: steps.cache-venv.outputs.cache-hit != 'true'
env:
AIOHTTP_NO_EXTENSIONS: 1
Expand All @@ -94,7 +95,12 @@ jobs:
uv pip install pytest-xdist
fi
- name: Cache base Python virtual environment
if: steps.cache-venv.outputs.cache-hit != 'true'
# Use `always()` so a cancellation (e.g. fail-fast from a sibling
# matrix job, or a concurrency cancel) cannot interrupt the save
# mid-upload and leave the cache key reserved but unpopulated.
# Guard on `create-venv` success so a failed/cancelled venv build
# is never cached.
if: always() && steps.create-venv.outcome == 'success'
uses: actions/cache/save@v5
with:
path: .venv
Expand Down