fix: reuse existing service by name instead of creating duplicates#208
fix: reuse existing service by name instead of creating duplicates#208Raymondhou0917 wants to merge 1 commit intozeabur:mainfrom
Conversation
…eabur#203) When deploying with `--project-id` and `--name` but without `--service-id`, the CLI now checks if a service with the same name already exists in the project. If found, it reuses that service instead of creating a duplicate with a suffixed name (e.g. "my-app-over"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 29 minutes and 39 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the deploy command to prevent duplicate services by reusing an existing service when deploying to a project with the same service name, addressing the duplicate *-over service creation issue in non-interactive deploys.
Changes:
- Look up existing services by
--namewithin the target--project-idbefore creating a new service. - Reuse the matched service ID and log a “Found existing service … redeploying…” message.
- Fall back to creating a new empty service only when no name match exists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| existingServices, err := f.ApiClient.ListAllServices(context.Background(), projectID) | ||
| if err != nil { | ||
| return fmt.Errorf("listing services: %w", err) | ||
| } | ||
| for _, s := range existingServices { | ||
| if s.Name == opts.name { | ||
| service = s | ||
| f.Log.Infof("Found existing service '%s', redeploying...", opts.name) | ||
| break | ||
| } |
pan93412
left a comment
pan93412
left a comment
There was a problem hiding this comment.
You need to resolve Copilot's suggestion (or explain why their suggestion is invalid)
Summary
--namealready exists in the projectFound existing service 'my-app', redeploying...Problem
When running
zeabur deploy --project-id <id> --name "my-app"and a service namedmy-appalready exists, the CLI creates a duplicate service namedmy-app-overinstead of updating the existing one.Changes
internal/cmd/deploy/deploy.go— added name-based lookup usingListAllServicesbeforeCreateEmptyServiceBefore/After
Fixes #203